]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
search: Actually crash when seeing errors from a native search provider
authorJasper St. Pierre <jstpierre@mecheye.net>
Fri, 26 Jul 2013 03:08:27 +0000 (23:08 -0400)
committerJasper St. Pierre <jstpierre@mecheye.net>
Tue, 29 Oct 2013 20:02:32 +0000 (16:02 -0400)
We don't implement many of these, and not catching the error lets us
see stack traces and other such information a lot faster.

https://bugzilla.gnome.org/show_bug.cgi?id=704912

js/ui/search.js

index 1fd442e1f044f42bf91eb75e0fe71bbbc6e14fa8..3648fa130a1c5b32c6b124e31347624742c6f78e 100644 (file)
@@ -82,22 +82,14 @@ const SearchSystem = new Lang.Class({
         if (isSubSearch) {
             for (let i = 0; i < this._providers.length; i++) {
                 let [provider, previousResults] = previousResultsArr[i];
-                try {
-                    results.push([provider, []]);
-                    provider.getSubsearchResultSet(previousResults, terms);
-                } catch (error) {
-                    log('A ' + error.name + ' has occured in ' + provider.id + ': ' + error.message);
-                }
+                results.push([provider, []]);
+                provider.getSubsearchResultSet(previousResults, terms);
             }
         } else {
             for (let i = 0; i < this._providers.length; i++) {
                 let provider = this._providers[i];
-                try {
-                    results.push([provider, []]);
-                    provider.getInitialResultSet(terms);
-                } catch (error) {
-                    log('A ' + error.name + ' has occured in ' + provider.id + ': ' + error.message);
-                }
+                results.push([provider, []]);
+                provider.getInitialResultSet(terms);
             }
         }
     }